Fix blank screen after notification request #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move it This wrapper is moved before <App /> because in a next commit I will add a component before <App /> which need useSecureBackgroundSplashScreen to have been executed.
…bview loading On Android, when we ask for notification permission, app goes to background. This was causing HttpServer to stop (which is an intented behavior futurepress/react-native-static-server#39), but it was stopped during Home webview loading leading to a blank screen. So now, we ask for notification permission before loading a webview.
Ldoppea
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Create a wrapper for useSecureBackgroundSplashScreen and move it
fix: Solve blank screen when asking notification permission during webview loading